Jackie-Jiang commented on code in PR #15461:
URL: https://github.com/apache/pinot/pull/15461#discussion_r2029260584
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java:
##########
@@ -206,8 +206,8 @@ private DimensionTable createFastLookupDimensionTable() {
// loading is in progress.
int token = _loadToken.incrementAndGet();
- Schema schema = ZKMetadataProvider.getTableSchema(_propertyStore,
_tableNameWithType);
- Preconditions.checkState(schema != null, "Failed to find schema for
dimension table: %s", _tableNameWithType);
+ Schema schema = _indexLoadingConfig.getSchema();
+ assert schema != null;
Review Comment:
The `IndexLoadingConfig` is cached with schema always set, thus the schema
can never be `null`. I usually use `assert` to avoid overhead and just let both
IDE and future developer know the field cannot be `null`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
