gortiz commented on code in PR #15433:
URL: https://github.com/apache/pinot/pull/15433#discussion_r2032889002
##########
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotClientRequest.java:
##########
@@ -559,6 +563,16 @@ public static Response
getPinotQueryResponse(BrokerResponse brokerResponse)
if (!exceptions.isEmpty()) {
// set the header value as first exception error code value.
queryErrorCodeHeaderValue = exceptions.get(0).getErrorCode();
+
+ // do log with the exception flagged with a particular marker for
filtering
+ MDC.put("queryErrorCode", Integer.toString(queryErrorCodeHeaderValue));
+ StringBuilder sb = new StringBuilder();
+ sb.append("Query processing exceptions:");
+ for (QueryProcessingException exception : exceptions) {
+ sb.append(" ").append(exception.toString());
+ }
Review Comment:
Do we also need to add it into the MDC? Markers are not enough to route the
error?
Anyway, can you modify the PR title/description?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
