Jackie-Jiang commented on code in PR #15496:
URL: https://github.com/apache/pinot/pull/15496#discussion_r2036158328
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/DefaultRebalancePreChecker.java:
##########
@@ -77,7 +78,9 @@ public Map<String, RebalancePreCheckerResult>
check(PreCheckContext preCheckCont
LOGGER.info("Start pre-checks for table: {} with rebalanceJobId: {}",
tableNameWithType, rebalanceJobId);
- Map<String, RebalancePreCheckerResult> preCheckResult = new HashMap<>();
+ // Right now pre-check items are done sequentially. If pre-check items are
to be done in parallel, we should not
+ // use linked hash map but to sort the result in the end
+ Map<String, RebalancePreCheckerResult> preCheckResult = new
LinkedHashMap<>();
Review Comment:
Since it is a small list, looping over should be okay. IMO it is a series of
checks, so it fits better into a `List`. E.g. if somehow we mistakenly apply
the same check twice, the second one shouldn't really override the first one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
