itschrispeck commented on code in PR #15542:
URL: https://github.com/apache/pinot/pull/15542#discussion_r2045300436
##########
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/recordtransformer/SchemaConformingTransformerTest.java:
##########
@@ -111,7 +111,7 @@ private static TableConfig createDefaultBasicTableConfig() {
SchemaConformingTransformerConfig schemaConformingTransformerConfig =
new SchemaConformingTransformerConfig(true,
INDEXABLE_EXTRAS_FIELD_NAME, true, UNINDEXABLE_EXTRAS_FIELD_NAME,
UNINDEXABLE_FIELD_SUFFIX, null, null, null, null, null, null,
false, null, null, null, null, null, null,
- null, null, null, null);
+ null, null, null, null, null);
Review Comment:
not introduced by this diff, but I think we should move to a builder pattern
here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
