rseetham commented on code in PR #15550:
URL: https://github.com/apache/pinot/pull/15550#discussion_r2045855825
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/TableConfigsRestletResource.java:
##########
@@ -161,6 +162,10 @@ public String getConfig(
try {
tableName = DatabaseUtils.translateTableName(tableName, headers);
Schema schema = _pinotHelixResourceManager.getTableSchema(tableName);
+ if (schema == null) {
+ throw new NotFoundException(
+ String.format("TableConfigs: %s schema does not exist. Use POST to
create it first.", tableName));
Review Comment:
Fixed it now.
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotHelixTaskResourceManager.java:
##########
@@ -961,7 +962,11 @@ private static String getPinotTaskName(String
helixJobName) {
* @return Task type
*/
private static String getTaskType(String name) {
- return name.split(TASK_NAME_SEPARATOR)[1];
+ String[] parts = name.split(TASK_NAME_SEPARATOR);
+ if (parts.length < 2) {
+ throw new IllegalArgumentException("Invalid task name (missing
separator): " + name);
Review Comment:
added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
