Jackie-Jiang commented on code in PR #15263:
URL: https://github.com/apache/pinot/pull/15263#discussion_r2052787843
##########
pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotEvaluateLiteralRule.java:
##########
@@ -258,13 +275,18 @@ private static Object convertResultValue(@Nullable Object
resultValue, RelDataTy
return TimestampUtils.toMillisSinceEpoch(resultValue.toString());
}
}
- // Return BigDecimal for numbers
- if (resultValue instanceof Integer || resultValue instanceof Long) {
+ // Use BigDecimal for INTEGER / BIGINT / DECIMAL literals
Review Comment:
Either way is fine. We can discuss the long term plan to make SSE and MSE
consistent separately
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
