somandal commented on code in PR #15619:
URL: https://github.com/apache/pinot/pull/15619#discussion_r2055077997
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentDriver.java:
##########
@@ -104,17 +106,15 @@ public InstancePartitions assignInstances(String
tierName, List<InstanceConfig>
private InstancePartitions getInstancePartitions(String
instancePartitionsName,
InstanceAssignmentConfig instanceAssignmentConfig, List<InstanceConfig>
instanceConfigs,
@Nullable InstancePartitions existingInstancePartitions,
- @Nullable InstancePartitions preConfiguredInstancePartitions, @Nullable
Boolean minimizeDataMovementOverride) {
+ @Nullable InstancePartitions preConfiguredInstancePartitions, Enablement
minimizeDataMovementEnablement) {
String tableNameWithType = _tableConfig.getTableName();
// minimizeDataMovement might be set back to false within
InstanceTagPoolSelector and InstancePartitionSelector
// if existingInstancePartitions is null.
boolean minimizeDataMovement =
- minimizeDataMovementOverride == null ?
instanceAssignmentConfig.isMinimizeDataMovement()
- : minimizeDataMovementOverride;
- LOGGER.info("Starting {} instance assignment for table {}, original
minimizeDataMovement: {}, "
- + "overriding with minimizeDataMovementOverride: {}",
instancePartitionsName, tableNameWithType,
- instanceAssignmentConfig.isMinimizeDataMovement(),
minimizeDataMovementOverride);
+
minimizeDataMovementEnablement.isEnabled(instanceAssignmentConfig::isMinimizeDataMovement);
+ LOGGER.info("Starting {} instance assignment for table: {} with
minimizeDataMovement: {}", instancePartitionsName,
Review Comment:
nit: shall we also log the
`instanceAssignmentConfig.isMinimizeDataMovement()` value for debugging
purposes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
