rajagopr commented on code in PR #15638:
URL: https://github.com/apache/pinot/pull/15638#discussion_r2060539580
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/SegmentDeletionManager.java:
##########
@@ -459,6 +466,32 @@ public void
removeAgedDeletedSegments(LeadControllerManager leadControllerManage
}
}
+ private static boolean deleteWithTimeout(PinotFS pinotFS, URI targetURI,
boolean forceDelete, long timeout,
+ TimeUnit timeUnit) {
+ CompletableFuture<Boolean> deleteFuture = CompletableFuture.supplyAsync(()
-> {
Review Comment:
+1. We should inspect how the clients are built and add timeouts to the
individual clients itself. All SDKs provide mechanism to pass timeouts and
retry strategies among others. This should be seen as a quick-fix without
causing regression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
