Jackie-Jiang commented on a change in pull request #4635: Support ORC files as
data source in segment creation
URL: https://github.com/apache/incubator-pinot/pull/4635#discussion_r328264281
##########
File path:
pinot-orc/src/main/java/org/apache/pinot/orc/data/readers/ORCRecordReader.java
##########
@@ -164,6 +165,8 @@ private Object getBaseObject(WritableComparable w) {
obj = ((DoubleWritable) w).get();
} else if (BytesWritable.class.isAssignableFrom(w.getClass())) {
obj = ((BytesWritable) w).getBytes();
+ } else if (ByteWritable.class.isAssignableFrom(w.getClass())) {
Review comment:
Can you put this between the boolean and short type for readability?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
