gortiz commented on PR #15609: URL: https://github.com/apache/pinot/pull/15609#issuecomment-2850946220
I've applied some last minute changes, including a new option to configure whether opchains should be kept or not when they finish successfully. By default, we will not keep them. This keeps the cache as small as possible, but the side effect is that we may lose important information when part of the query finishes successfully early and then another part fails. When `pinot.server.query.op.stats.cache.invalidate.on.success` is false, these successfully ended opchains will be kept in the cache. The effect is that the cache will rotate more often. In high QPS environments, this may mean that queries that fail may be unable to find their stats. In future we can introduce a query option to disable successful invalidation on query bases, which could be useful when users write new queries. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
