J-HowHuang commented on code in PR #15618:
URL: https://github.com/apache/pinot/pull/15618#discussion_r2076076577
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##########
@@ -485,7 +485,8 @@ private RebalanceResult doRebalance(TableConfig
tableConfig, RebalanceConfig reb
externalViewCheckIntervalInMs,
externalViewStabilizationTimeoutInMs, estimatedAverageSegmentSizeInBytes,
allSegmentsFromIdealState, tableRebalanceLogger);
} catch (Exception e) {
- String errorMsg = "Caught exception while waiting for ExternalView to
converge, aborting the rebalance";
+ String errorMsg =
+ "Caught exception while waiting for ExternalView to converge,
aborting the rebalance: " + e.getMessage();
Review Comment:
Right but we need this at the later
`_tableRebalanceObserver.onError(errorMsg)` to bubble the exception info into
ZK. To make it consistent between ZK and log, I log (warn) the same text as
shown in ZK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
