wirybeaver commented on code in PR #15203:
URL: https://github.com/apache/pinot/pull/15203#discussion_r2076332040
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/config/QueryOptionsUtils.java:
##########
@@ -182,6 +185,19 @@ public static Integer
getNumReplicaGroupsToQuery(Map<String, String> queryOption
return checkedParseIntPositive(QueryOptionKey.NUM_REPLICA_GROUPS_TO_QUERY,
numReplicaGroupsToQuery);
}
+ public static List<Integer> getOrderedPreferredReplicas(Map<String, String>
queryOptions) {
+ String orderedPreferredReplicas =
queryOptions.get(QueryOptionKey.ORDERED_PREFERRED_REPLICAS);
+ if (orderedPreferredReplicas == null) {
+ return Collections.emptyList();
+ }
+ String[] replicas = orderedPreferredReplicas.split("\\|");
Review Comment:
self review: cannot use comma as the delimiter of replica group list because
query option use comma as the delimiter of different options
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
