vrajat commented on code in PR #15720:
URL: https://github.com/apache/pinot/pull/15720#discussion_r2077200445
##########
pinot-common/src/main/java/org/apache/pinot/common/config/provider/TableCache.java:
##########
@@ -663,6 +668,30 @@ public synchronized void handleDataDeleted(String path) {
}
}
+ private static Map<Expression, Expression> crateExpressionOverrideMap(String
tableName, QueryConfig queryConfig) {
Review Comment:
Typo in function name. `create` instead of `crate`
##########
pinot-controller/src/test/java/org/apache/pinot/controller/api/resources/PinotLogicalTableResourceTest.java:
##########
@@ -197,6 +200,88 @@ public void testLogicalTableValidationTests()
assertTrue(e.getMessage().contains("Reason: 'InvalidTenant' should be
one of the existing broker tenants"),
e.getMessage());
}
+
+ // Test ref offline table name is null validation
Review Comment:
Can these be separate tests ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
