This is an automated email from the ASF dual-hosted git repository.
siddteotia pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 05b8fad2a3 Japicmp implementation in pinot-segment-spi (#15737)
05b8fad2a3 is described below
commit 05b8fad2a33a13725d6fd35c9a72c06c43991669
Author: Matthew Jack <[email protected]>
AuthorDate: Wed May 7 14:53:50 2025 -0700
Japicmp implementation in pinot-segment-spi (#15737)
* committing japicmp logic. note that this is already pushed to
apache/pinot via a PR
* Adding japicmp implementation to pinot-segment-spi. This has been tested.
Adding baseline pinot-segment-spi .jar for japicmp to use for comparison.
* Updated formatting of comment in the pom file, per Tianle.
* second change to comment formatting
---
pinot-segment-spi/pom.xml | 63 +++++++++++++++++++++
.../pinot-segment-spi-japicmp-baseline.jar | Bin 0 -> 337822 bytes
pinot-spi/pom.xml | 8 +--
3 files changed, 67 insertions(+), 4 deletions(-)
diff --git a/pinot-segment-spi/pom.xml b/pinot-segment-spi/pom.xml
index 1c0dc9e176..64363c3199 100644
--- a/pinot-segment-spi/pom.xml
+++ b/pinot-segment-spi/pom.xml
@@ -34,6 +34,69 @@
<pinot.root>${basedir}/..</pinot.root>
</properties>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>com.github.siom79.japicmp</groupId>
+ <artifactId>japicmp-maven-plugin</artifactId>
+ <version>0.23.1</version>
+ <configuration>
+ <!-- If oldVersion were left blank, 1.3.0 would be the baseline
version for japicmp's comparing. However, we already
+ introduced back-incompatible changes since the release of
1.4.0-SNAPSHOT, so we are using a baseline .jar of the repo here
+ (with version as of PR #15737).
+ TODO: At the time of the next Pinot release (1.4.0), update the
baseline version here to 1.4.0 and remove
pinot-segment-spi/resources/pinot-segment-spi-japicmp-baseline.jar from repo.-->
+ <oldVersion>
+ <file>
+
<path>${basedir}/resources/pinot-segment-spi-japicmp-baseline.jar</path>
+ </file>
+ </oldVersion>
+ <newVersion>
+ <file>
+
<path>${project.build.directory}/${project.artifactId}-${project.version}.jar</path>
+ </file>
+ </newVersion>
+ <parameter>
+ <includes>org.apache.pinot.segment.spi</includes>
+ <onlyModified>true</onlyModified>
+ <skipXmlReport>true</skipXmlReport>
+ <skipHtmlReport>true</skipHtmlReport>
+
<breakBuildOnSourceIncompatibleModifications>true</breakBuildOnSourceIncompatibleModifications>
+ <overrideCompatibilityChangeParameters>
+ <overrideCompatibilityChangeParameter>
+ <compatibilityChange>METHOD_NOW_VARARGS</compatibilityChange>
+ <sourceCompatible>false</sourceCompatible>
+ </overrideCompatibilityChangeParameter>
+ <overrideCompatibilityChangeParameter>
+
<compatibilityChange>METHOD_ABSTRACT_ADDED_IN_IMPLEMENTED_INTERFACE</compatibilityChange>
+ <sourceCompatible>true</sourceCompatible>
+ </overrideCompatibilityChangeParameter>
+ <overrideCompatibilityChangeParameter>
+
<compatibilityChange>METHOD_ABSTRACT_ADDED_IN_SUPERCLASS</compatibilityChange>
+ <sourceCompatible>true</sourceCompatible>
+ </overrideCompatibilityChangeParameter>
+ <overrideCompatibilityChangeParameter>
+
<compatibilityChange>METHOD_ABSTRACT_ADDED_TO_CLASS</compatibilityChange>
+ <sourceCompatible>true</sourceCompatible>
+ </overrideCompatibilityChangeParameter>
+ <overrideCompatibilityChangeParameter>
+
<compatibilityChange>METHOD_ADDED_TO_INTERFACE</compatibilityChange>
+ <sourceCompatible>true</sourceCompatible>
+ </overrideCompatibilityChangeParameter>
+ </overrideCompatibilityChangeParameters>
+ </parameter>
+ </configuration>
+ <executions>
+ <execution>
+ <phase>verify</phase>
+ <goals>
+ <goal>cmp</goal>
+ </goals>
+ </execution>
+ </executions>
+ </plugin>
+ </plugins>
+ </build>
+
<dependencies>
<dependency>
<groupId>org.apache.pinot</groupId>
diff --git a/pinot-segment-spi/resources/pinot-segment-spi-japicmp-baseline.jar
b/pinot-segment-spi/resources/pinot-segment-spi-japicmp-baseline.jar
new file mode 100644
index 0000000000..566ebe05de
Binary files /dev/null and
b/pinot-segment-spi/resources/pinot-segment-spi-japicmp-baseline.jar differ
diff --git a/pinot-spi/pom.xml b/pinot-spi/pom.xml
index c5b2b71a89..3d1910754f 100644
--- a/pinot-spi/pom.xml
+++ b/pinot-spi/pom.xml
@@ -129,15 +129,15 @@
<artifactId>japicmp-maven-plugin</artifactId>
<version>0.23.1</version>
<configuration>
+ <!-- If oldVersion were left blank, 1.3.0 would be the baseline
version for japicmp's comparing. However, we already
+ introduced back-incompatible changes since the release of
1.4.0-SNAPSHOT, so we are using a baseline .jar of the repo here
+ (with version as of PR #15684).
+ TODO: At the time of the next Pinot release (1.4.0), update the
baseline version here to 1.4.0 and remove
pinot-spi/resources/pinot-spi-japicmp-baseline.jar from repo.-->
<oldVersion>
<file>
<path>${basedir}/resources/pinot-spi-japicmp-baseline.jar</path>
</file>
</oldVersion>
-<!-- If oldVersion were left blank, 1.3.0 would be the baseline version for
japicmp's comparing. However, we already
-introduced back-incompatible changes since the release of 1.4.0-SNAPSHOT, so
we are using a baseline .jar of the repo here
-(with version as of PR #15684).
-TODO: At the time of the next Pinot release (1.4.0), update the baseline
version here to 1.4.0 and remove
pinot-spi/resources/pinot-spi-japicmp-baseline.jar from repo.-->
<newVersion>
<file>
<path>${project.build.directory}/${project.artifactId}-${project.version}.jar</path>
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
