UOETianleZhang commented on code in PR #15739:
URL: https://github.com/apache/pinot/pull/15739#discussion_r2080668807
##########
.github/workflows/scripts/.pinot_linter.sh:
##########
@@ -25,9 +25,8 @@ java -version
ifconfig
netstat -i
-
mvn -B -ntp -T1C license:check || exit 1
mvn -B -ntp -T1C checkstyle:check || exit 1
mvn -B -ntp -T1C spotless:check || exit 1
-mvn -B -ntp -T1C enforcer:enforce || exit 1
+mvn -B -ntp -T1C enforcer:enforce -Pdependency-verifier
-Drun.dependency.verifier=true || exit 1
Review Comment:
Thanks for figuring it out! I think the future plugin developer can follow
the similar steps to make development/test. Could you add a readme in the
pinot-dependency-verifier model with the test steps?
##########
pom.xml:
##########
@@ -306,9 +312,76 @@
<assertj.version>3.27.3</assertj.version>
<archiver.compress>true</archiver.compress>
<archiver.recompressZippedFiles>true</archiver.recompressZippedFiles>
+
+ <run.dependency.verifier>false</run.dependency.verifier>
Review Comment:
Also it would be better to add a comment here to indicate why we need this
option
##########
pom.xml:
##########
@@ -306,9 +312,76 @@
<assertj.version>3.27.3</assertj.version>
<archiver.compress>true</archiver.compress>
<archiver.recompressZippedFiles>true</archiver.recompressZippedFiles>
+
+ <run.dependency.verifier>false</run.dependency.verifier>
Review Comment:
Could you make it true by default? The idea is to let maven-enforcer-plugin
to be executed by default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
