Jackie-Jiang commented on code in PR #15803:
URL: https://github.com/apache/pinot/pull/15803#discussion_r2093680517
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/TextIndexConfig.java:
##########
@@ -98,6 +100,21 @@ static DocIdTranslatorMode of(String mode) {
}
}
+ public TextIndexConfig(Boolean disabled, FSTType fstType, Object
rawValueForTextIndex, boolean enableQueryCache,
Review Comment:
Hmm, in that case I feel it is just too strict :(
I feel we can ignore the test failure since we know exactly why it fails
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/text/TextIndexConfigBuilder.java:
##########
@@ -106,6 +106,11 @@ public TextIndexConfig.AbstractBuilder
withProperties(@Nullable Map<String, Stri
_fstType = FSTType.LUCENE;
}
}
+
+ if
(textIndexProperties.get(FieldConfig.TEXT_INDEX_LUCENE_CASE_SENSITIVE_INDEX) !=
null) {
Review Comment:
What I meant is that we don't need to introduce
`FieldConfig.TEXT_INDEX_LUCENE_CASE_SENSITIVE_INDEX`. You may modify the test
table config to use the json format of the config
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
