gortiz commented on code in PR #15762:
URL: https://github.com/apache/pinot/pull/15762#discussion_r2095735336
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/channel/MailboxContentObserver.java:
##########
@@ -51,8 +52,10 @@ public class MailboxContentObserver implements
StreamObserver<MailboxContent> {
private final List<ByteBuffer> _mailboxBuffers;
private transient ReceivingMailbox _mailbox;
- public MailboxContentObserver(MailboxService mailboxService,
StreamObserver<MailboxStatus> responseObserver) {
+ public MailboxContentObserver(
+ MailboxService mailboxService, String mailboxId,
StreamObserver<MailboxStatus> responseObserver) {
_mailboxService = mailboxService;
+ _mailbox = StringUtils.isNotBlank(mailboxId) ?
_mailboxService.getReceivingMailbox(mailboxId) : null;
Review Comment:
Shouldn't we also remove the first lines of `onNext` given that this is now
something that is included at construction time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
