Jackie-Jiang commented on code in PR #15829:
URL: https://github.com/apache/pinot/pull/15829#discussion_r2096648771
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -3860,7 +3862,9 @@ private String updateSegmentTargetTier(String
tableNameWithType, String segmentN
}
// Update the tier in segment ZK metadata and write it back to ZK.
segmentZKMetadata.setTier(targetTierName);
- updateZkMetadata(tableNameWithType, segmentZKMetadata,
segmentMetadataZNRecord.getVersion());
+ if (!enableParallelPushProtection) {
+ updateZkMetadata(tableNameWithType, segmentZKMetadata,
segmentMetadataZNRecord.getVersion());
Review Comment:
What happens if `enableParallelPushProtection` is set to `false`? Does this
method become no-op?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
