abhishekbafna commented on code in PR #15839:
URL: https://github.com/apache/pinot/pull/15839#discussion_r2097255473
##########
pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BrokerResourceOnlineOfflineStateModelFactory.java:
##########
@@ -97,14 +98,14 @@ public void onBecomeOnlineFromOffline(Message message,
NotificationContext conte
@Transition(from = "ONLINE", to = "OFFLINE")
public void onBecomeOfflineFromOnline(Message message, NotificationContext
context) {
- String tableNameWithType = message.getPartitionName();
- LOGGER.info("Processing transition from ONLINE to OFFLINE for table:
{}", tableNameWithType);
+ String physicalOrLogicalTable = message.getPartitionName();
+ LOGGER.info("Processing transition from ONLINE to OFFLINE for table:
{}", physicalOrLogicalTable);
try {
- _routingManager.removeRouting(tableNameWithType);
- _queryQuotaManager.dropTableQueryQuota(tableNameWithType);
+ _routingManager.removeRouting(physicalOrLogicalTable);
Review Comment:
This was not missed, we created a separate issue for remove table handling.
https://github.com/apache/pinot/issues/15835
For the logical table, when a table is deleted, it would print.
`LOGGER.warn("Routing does not exist for table: {}, skipping removing
routing", tableNameWithType);`
The reason is because, routing map does not have logical table so the skip
message. It should be alright.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
