vrajat commented on code in PR #15773:
URL: https://github.com/apache/pinot/pull/15773#discussion_r2099928609
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/physical/DispatchablePlanMetadata.java:
##########
@@ -80,6 +81,24 @@ public class DispatchablePlanMetadata implements
Serializable {
// Map from workerId -> {planFragmentId -> mailboxes}
private final Map<Integer, Map<Integer, MailboxInfos>>
_workerIdToMailboxesMap = new HashMap<>();
+ /**
+ * Map from workerId -> {tableType -> {tableName -> segments}} is required
for logical tables.
+ * Raw definition of the map is:
+ * Map<String, Map<String, Map<String, List<String>>>>. Since this
definition is hard to understand - specifically
+ * what do each of the string keys store, we define two classes:
+ * {@link TableTypeToSegmentsMap} and {@link
TableTypeTableNameToSegmentsMap} to help read code more easily.
+ */
+ public static class TableTypeToSegmentsMap {
Review Comment:
Doh! - Simplified the data structure to `Map<String, List<String>>`. I
realised that the data structure has physical table name AND table type. So now
it is a map of `physicalTableName -> segments`.
I did this AFTER spending a lot of time thinking about jackson map
serialization and other related issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
