Jackie-Jiang commented on code in PR #15526:
URL: https://github.com/apache/pinot/pull/15526#discussion_r2103407592
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/json/ImmutableJsonIndexReader.java:
##########
@@ -120,15 +120,22 @@ public ImmutableJsonIndexReader(PinotDataBuffer
dataBuffer, int numDocs) {
}
@Override
- public MutableRoaringBitmap getMatchingDocIds(String filterString) {
+ public MutableRoaringBitmap getMatchingDocIds(String filterObj) {
FilterContext filter;
try {
- filter =
RequestContextUtils.getFilter(CalciteSqlParser.compileToExpression(filterString));
+ filter =
RequestContextUtils.getFilter(CalciteSqlParser.compileToExpression((String)
filterObj));
Preconditions.checkArgument(!filter.isConstant());
} catch (Exception e) {
- throw new BadQueryRequestException("Invalid json match filter: " +
filterString);
+ throw new BadQueryRequestException("Invalid json match filter: " +
filterObj);
}
-
+ return getMatchingDocIds(filter);
+ }
+ @Override
Review Comment:
(minor) Add an empty line
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/json/ImmutableJsonIndexReader.java:
##########
@@ -120,15 +120,22 @@ public ImmutableJsonIndexReader(PinotDataBuffer
dataBuffer, int numDocs) {
}
@Override
- public MutableRoaringBitmap getMatchingDocIds(String filterString) {
+ public MutableRoaringBitmap getMatchingDocIds(String filterObj) {
Review Comment:
Don't change the argument name. The cast is also redundant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
