tarun11Mavani commented on code in PR #15863:
URL: https://github.com/apache/pinot/pull/15863#discussion_r2105786201


##########
pinot-controller/src/main/java/org/apache/pinot/controller/util/ServerSegmentMetadataReader.java:
##########
@@ -399,6 +400,34 @@ public ValidDocIdsBitmapResponse 
getValidDocIdsBitmapFromServer(String tableName
     return response;
   }
 
+  /**
+   * Retrieves the creation time metadata for each segment of a given table 
from the each servers the segment is hosted.
+   *
+   * @param tableNameWithType The name of the table with type (e.g., 
myTable_OFFLINE)
+   * @param serverToSegmentsMap A map from server instance to the list of 
segments it hosts
+   * @param serverToEndpoints A BiMap from server instance to its admin 
endpoint

Review Comment:
   It's actually a BiMap of server instance to admin endpoint.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to