ankitsultana commented on code in PR #15941:
URL: https://github.com/apache/pinot/pull/15941#discussion_r2114920308
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/physical/PinotDispatchPlanner.java:
##########
@@ -120,16 +117,6 @@ private void runValidations(PlanFragment planFragment,
DispatchablePlanContext c
}
}
- // TODO: Switch to Worker SPI to avoid multiple-places where workers are
assigned.
- private void runPhysicalOptimizers(PlanNode subPlanRoot,
DispatchablePlanContext dispatchablePlanContext,
- TableCache tableCache) {
- if
(dispatchablePlanContext.getPlannerContext().getOptions().getOrDefault("useColocatedJoin",
"false")
- .equals("true")) {
Review Comment:
for folks without context, the Greedy* code was called only if you had set
the `useColocatedJoin` flag. This feature had broken around a year back due to
MSE evolution, and the design of this class being outdated.
Hence removing this should be safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
