KKcorps commented on code in PR #15641:
URL: https://github.com/apache/pinot/pull/15641#discussion_r2122657503
##########
pinot-plugins/pinot-stream-ingestion/pinot-kafka-2.0/src/main/java/org/apache/pinot/plugin/stream/kafka20/KafkaPartitionLevelConnectionHandler.java:
##########
@@ -56,6 +56,8 @@ public abstract class KafkaPartitionLevelConnectionHandler {
protected final Consumer<String, Bytes> _consumer;
protected final TopicPartition _topicPartition;
protected final Properties _consumerProp;
+ // Admin client for thread-safe offset lookups
+ protected final AdminClient _adminClient;
Review Comment:
Admin client overhead is less than 100ms always
Consumer client overhead is an order of magnitude more sometimes
Change the PR so that we create admin client on demand
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
