gortiz commented on code in PR #15694:
URL: https://github.com/apache/pinot/pull/15694#discussion_r2131598394
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/GrpcSendingMailbox.java:
##########
@@ -121,12 +112,31 @@ private void sendInternal(MseBlock block,
List<DataBuffer> serializedStats)
if (_contentObserver == null) {
_contentObserver = getContentObserver();
}
- splitAndSend(block, serializedStats);
+ processAndSend(block, serializedStats);
if (LOGGER.isDebugEnabled()) {
LOGGER.debug("==[GRPC SEND]== message " + block + " sent to: " + _id);
}
}
+ private void processAndSend(MseBlock block, List<DataBuffer> serializedStats)
+ throws IOException {
+ _statMap.merge(MailboxSendOperator.StatKey.RAW_MESSAGES, 1);
+ long start = System.currentTimeMillis();
+ try {
+ DataBlock dataBlock = MseBlockSerializer.toDataBlock(block,
serializedStats);
+ int sizeInBytes = _sender.processAndSend(dataBlock);
+ if (LOGGER.isDebugEnabled()) {
+ LOGGER.debug("Serialized block: {} to {} bytes", block, sizeInBytes);
+ }
+ _statMap.merge(MailboxSendOperator.StatKey.SERIALIZED_BYTES,
sizeInBytes);
+ } catch (Throwable t) {
+ LOGGER.warn("Caught exception while serializing block: {}", block, t);
+ throw t;
Review Comment:
I'm changing this code in https://github.com/apache/pinot/pull/16010, so one
of the two PRs will need to resolve conflicts. I'm going to merge this PR
before mine because I think it is going to be easier to resolve the conflict
this way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
