yashmayya commented on code in PR #16043:
URL: https://github.com/apache/pinot/pull/16043#discussion_r2140142627
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/plan/server/ServerPlanRequestUtils.java:
##########
@@ -114,6 +123,11 @@ public static OpChain compileLeafStage(
// 2. Convert PinotQuery into InstanceRequest list (one for each physical
table)
PinotQuery pinotQuery = serverContext.getPinotQuery();
pinotQuery.setExplain(explain);
+
+ if (MapUtils.isNotEmpty(rowFilters)) {
+ pinotQuery.setQueryOptions(rowFilters);
+ }
Review Comment:
Can this be consolidated within the `updateQueryOptions` method that is
called when converting the `PinotQuery` into an `InstanceRequest` so that we
avoid having multiple different places where the query options are set
(eliminates the risk of accidentally overwriting query options)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
