yashmayya commented on code in PR #15203:
URL: https://github.com/apache/pinot/pull/15203#discussion_r2140688887
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/BrokerMeter.java:
##########
@@ -50,6 +50,24 @@ public class BrokerMeter implements AbstractMetrics.Meter {
* That means it can be used to know how many single-stage queries have been
started in total.
*/
public static final BrokerMeter QUERIES_GLOBAL = create("QUERIES_GLOBAL",
"queries", true);
+ /**
+ * Number of queries executed per replica group.
+ * <p>
+ * This metric is used to monitor query traffic distribution across replica
groups.
+ * Currently only includes single-stage queries.
+ */
+ public static final BrokerMeter REPLICA_QUERIES = create("REPLICA_QUERIES",
"routing", false);
+ /**
+ * Number of segment selected per replica gorup during query execution.
+ * <p>
+ * This metric is not global and is attached to a particular replica group.
+ * Currently this counter include single stage queries only.
+ * <p>
+ * Let's say the query option orderedReferredReplicas is set and a few nodes
in the preferred replica group are down.
+ * The other metric {@link #REPLICA_QUERIES} shows the traffic are
relatively equal over replica groups.
+ * This metric is still going to show that most of segments are still
selected from the preferred replica group.
+ */
+ public static final BrokerMeter REPLICA_SEG_QUERIES =
create("REPLICA_SEG_QUERIES", "routing", false);
Review Comment:
Same concerns about instance pool vs replica group for these metrics as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
