Jackie-Jiang commented on code in PR #16045:
URL: https://github.com/apache/pinot/pull/16045#discussion_r2143735230
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##########
@@ -1257,6 +1261,59 @@ public SuccessResponse deleteSegmentsFromSequenceNum(
return new SuccessResponse("Successfully deleted segments for table: " +
tableNameWithType);
}
+ @DELETE
+ @Path("/segments/{tableNameWithType}/{segmentName}/ingestion-metrics")
Review Comment:
The most common case would be a partition rebalanced to a different set of
servers, thus we need to drop metrics for some server but not all serving
servers.
Currently `IngestionMetricsRemoveMessage` is designed to handle the case
when a new consuming segment is assigned to a different server, thus it takes
the committing segment name as the parameter to ensure the committing segment
won't add the metrics back. When we manually remove the ingestion metrics, we
don't need to worry about this. We can consider adding a new message, or simply
open a rest API on server side to remove ingestion metrics for a given table
and partition id.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
