Jackie-Jiang commented on PR #15350: URL: https://github.com/apache/pinot/pull/15350#issuecomment-2968471995
Applied a commit for some misc fixes and cleanups. Changes worth noting: - Do not add virtual data source into immutable segment to avoid thread safety issue - Do not check invalid segment against table level schema. It is invalid setup if a column doesn't exist in the table level schema, and we just throw exception in that case - For empty segment, return a proper `EmptyDataSource` if column exists in table schema - Binary incompatibility comes from removing default implementation for `IndexSegment.getDataSource()`, which should be fine giving it is internal facing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
