J-HowHuang commented on PR #16144: URL: https://github.com/apache/pinot/pull/16144#issuecomment-2992994335
@somandal > Should we fail the rebalance if a number outside of 0.0 and 1.0 is provided? or consider it as disabled if set to some invalid number? Let's not fail it as it's minor (the threshold is only used in the number comparison). I now cap it to [0.0, 1.0] in the pre-checker, which should be enough. @himanish-star I updated the component to have `valueStep` `valueMin` and `valueMax`, please let me know if this is okay. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
