vrajat opened a new pull request, #16172: URL: https://github.com/apache/pinot/pull/16172
The following logging improvements have been made to the OOM Protection module: * Convert thread registration & de-registration logs to DEBUG * Add a log function to take snapshot of the state when queries are killed. Previously these logs were inline. Also the snapshot was not logged in `PerQueryCPUMemAccountant.WatcherTask.killAllQueries`. An unrelated improvement is that in the `else` block of `PerQueryCPUMemAccountant.WatcherTask.killMostExpensiveQuery`, cpu time was considered if memory sampling is off. This can lead to serious jeopardy. The block is executed if `accounting.oom.enable.killing.query` is true AND `accounting.enable.thread.memory.sampling`. Rather this invalid configuration should be ignored or handled correctly. So the if block has been removed. Closes #16111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
