praveenc7 commented on code in PR #15109:
URL: https://github.com/apache/pinot/pull/15109#discussion_r2118391891
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -2209,6 +2219,8 @@ public void setExistingTableConfig(TableConfig
tableConfig, int expectedVersion)
// Send update query quota message if quota is specified
sendTableConfigRefreshMessage(tableNameWithType);
+ // TODO: Propagate workload for tables if there is change is change
instance characteristics
+ _queryWorkloadManager.propagateWorkloadFor(tableNameWithType);
}
public void deleteUser(String username) {
Review Comment:
I think we discussed this offline as well on what are actions we should be
doing on table deletion
like Cleaning up QueryWorkloadConfig associated with the table.
This would require updating the QueryWorkloadConfig to remove all
table/tenant entries in the workloadConfig, currently the queryworkload config
is only updated on POST operation, there might be some race condition. In order
to handle that well, I will take an AI to do this i n a follow PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
