ankitsultana commented on code in PR #16204:
URL: https://github.com/apache/pinot/pull/16204#discussion_r2167996730
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/physical/v2/mapping/PinotDistMapping.java:
##########
@@ -90,6 +93,13 @@ public static RelCollation apply(RelCollation relCollation,
PinotDistMapping map
return RelCollations.of(newFieldCollations);
Review Comment:
Yeah that was by design because I wanted to keep it simple at the time. For
context, this can occur in scenarios such as follows (which are rare or
unlikely):
```
Project(col1=$0, col2=$0)
Sort(collation=[order by $0 desc])
TableScan(col1)
```
In this case, the project could be said to be ordered by both col1 and col2,
but for now I am only preserving one of the indices to keep things simple. But
I think it should be okay to add all field indexes too. I can take that up in a
follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
