ankitsultana commented on code in PR #16242:
URL: https://github.com/apache/pinot/pull/16242#discussion_r2181156366
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/partitioning/MultiColumnKeySelector.java:
##########
@@ -56,15 +62,20 @@ public int computeHash(Object[] input) {
// also see: https://github.com/apache/pinot/issues/9998
//
// TODO: consider better hashing algorithms than hashCode sum, such as
XOR'ing
- int hashCode = 0;
+ Object[] values = new Object[_keyIds.length];
Review Comment:
hmm this excess allocation is not good. Could you change the signature of
computeMultiHash so it passes keyIds and the input through?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
