ankitsultana commented on code in PR #16242:
URL: https://github.com/apache/pinot/pull/16242#discussion_r2188488971
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/serde/PlanNodeDeserializer.java:
##########
@@ -134,7 +134,7 @@ private static MailboxSendNode
deserializeMailboxSendNode(Plan.PlanNode protoNod
receiverIds,
convertExchangeType(protoMailboxSendNode.getExchangeType()),
convertDistributionType(protoMailboxSendNode.getDistributionType()),
protoMailboxSendNode.getKeysList(),
protoMailboxSendNode.getPrePartitioned(),
convertCollations(protoMailboxSendNode.getCollationsList()),
- protoMailboxSendNode.getSort());
+ protoMailboxSendNode.getSort(),
protoMailboxSendNode.getHashFunction());
Review Comment:
Before I was thinking that this should be okay since we expect rollout to be
done in the order controller ==> broker ==> server.
But I see that for `protoReceiverIds` we have added defensive handling for
null or empty list to handle the case when a broker is not updated. (see L125
in this file)
Can you add the same for hashFunction?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
