vvivekiyer commented on code in PR #15798:
URL: https://github.com/apache/pinot/pull/15798#discussion_r2195472834
##########
pinot-spi/src/main/java/org/apache/pinot/spi/trace/Tracing.java:
##########
@@ -301,6 +327,7 @@ public static void clear() {
public static void initializeThreadAccountant(PinotConfiguration config,
String instanceId,
InstanceType instanceType) {
String factoryName =
config.getProperty(CommonConstants.Accounting.CONFIG_OF_FACTORY_NAME);
+ _workloadBudgetManager = new WorkloadBudgetManager(config);
Review Comment:
We discussed this offline. Summarizing here:
- We'll be exercising caution and ensure that `ResourceUsage..Acountant` has
feature parity and stability before deprecating `PerQuery...Accountant`
- Moved WorkloadBudgetManager to core.
- WorkloadBudgetManager is not initialized. It fast exits if the config for
workload budget collection is not enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
