yashmayya commented on code in PR #16202:
URL: https://github.com/apache/pinot/pull/16202#discussion_r2197481318
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTenantRestletResource.java:
##########
@@ -386,23 +394,38 @@ private void
persistInstancePartitionsHelper(InstancePartitions instancePartitio
}
}
- private String getTablesServedFromServerTenant(String tenantName, @Nullable
String database) {
+ private String getTablesServedFromServerTenant(String tenantName, @Nullable
String database,
+ boolean withTableProperties) {
Set<String> tables = new HashSet<>();
+ Set<TenantTableWithProperties> tablePropertiesMap = withTableProperties ?
new HashSet<>() : null;
Review Comment:
Actually, I just noticed that you're only ever using the map's values? Why
not keep it a set in that case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
