avshenuk commented on PR #16366:
URL: https://github.com/apache/pinot/pull/16366#issuecomment-3083368104
A few tests failed due to:
```
java.sql.SQLException: Failed to execute query : SELECT 1 from
nonExistingTable LIMIT 1000000
at
org.apache.pinot.client.PinotStatement.executeQuery(PinotStatement.java:75)
at
org.apache.pinot.integration.tests.OfflineClusterIntegrationTest.testNonExistingTableQueryThroughJDBCClient(OfflineClusterIntegrationTest.java:3860)
at
java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
at
org.testng.internal.invokers.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:141)
at
org.testng.internal.invokers.TestInvoker.invokeMethod(TestInvoker.java:687)
at
org.testng.internal.invokers.TestInvoker.invokeTestMethod(TestInvoker.java:230)
at
org.testng.internal.invokers.MethodRunner.runInSequence(MethodRunner.java:63)
at
org.testng.internal.invokers.TestInvoker$MethodInvocationAgent.invoke(TestInvoker.java:995)
at
org.testng.internal.invokers.TestInvoker.invokeTestMethods(TestInvoker.java:203)
at
org.testng.internal.invokers.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:154)
at
org.testng.internal.invokers.TestMethodWorker.run(TestMethodWorker.java:134)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
at org.testng.TestRunner.privateRun(TestRunner.java:741)
at org.testng.TestRunner.run(TestRunner.java:616)
at org.testng.SuiteRunner.runTest(SuiteRunner.java:421)
at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:413)
at org.testng.SuiteRunner.privateRun(SuiteRunner.java:373)
at org.testng.SuiteRunner.run(SuiteRunner.java:312)
at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:95)
at org.testng.TestNG.runSuitesSequentially(TestNG.java:1274)
at org.testng.TestNG.runSuitesLocally(TestNG.java:1208)
at org.testng.TestNG.runSuites(TestNG.java:1112)
at org.testng.TestNG.run(TestNG.java:1079)
at com.intellij.rt.testng.IDEARemoteTestNG.run(IDEARemoteTestNG.java:65)
at
com.intellij.rt.testng.RemoteTestNGStarter.main(RemoteTestNGStarter.java:105)
Caused by: org.apache.pinot.client.PinotClientException: Could not find
broker to query with no tables
```
I've added a fallback mechanism similar to what was already done in
DynamicBrokerSelector: choose a random broker if none is found for a given
table.
Since the assumption seems to be that such a query should just return an
empty result, and not fail with an exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
