vrajat commented on PR #16374: URL: https://github.com/apache/pinot/pull/16374#issuecomment-3084853107
> I understand the intention of the change to improve performance. Have we validated through some integ-test or running in a prod like environment with actual queries that it doesn't cause any functionality regression. > > Can we wait a till Monday before we merge? Let me check why we added forced GC. I think we did some analysis when adding this @praveenc7 - Would definitely like to understand why this was added. This call is consistently causing a major collection and pausing the JVM both in production and a cluster test based on production-sized dataset and workloads. Java Docs also mention this is should be generally avoided: https://www.oracle.com/java/technologies/javase/gc-tuning-6.html#other_considerations You can check the JFR screenshot in the attached issue https://github.com/apache/pinot/issues/16373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
