Jackie-Jiang commented on PR #16388: URL: https://github.com/apache/pinot/pull/16388#issuecomment-3098681489
> why do kafka/pulsar/kinesis no longer have `extends StreamMessageMetadata`? These classes are already not used as `StreamMessageMetadata`, and only serves as util class. `StreamMessageMetadata` doesn't need to be extended > We do have our own `PartitionGroupConsumer `. Things that will break for us: > > * we use `RowMetadata` > * our implementation of `MessageBatch` is probably relying on some defaults > > Our deployments require updating server code then plugin code. It seems `StreamMessageMetadata` is fully replacing `RowMetadata`. Though right now it implements `RowMetadata`. I'm not sure we'll know if java allows this intermediate state where `RowMetadata` is removed in just the server code. `RowMetadata` is not used in the plug-in module. Can you check the usage of `RowMetadata`? I'll hold on this PR for some time (probably this week), and let me know if you need certain adjustment to be made -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
