noob-se7en commented on code in PR #16407:
URL: https://github.com/apache/pinot/pull/16407#discussion_r2242202323
##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/BaseServerStarter.java:
##########
@@ -797,7 +797,7 @@ public void start()
Collections.singletonMap(Helix.IS_SHUTDOWN_IN_PROGRESS,
Boolean.toString(false)));
_isServerReadyToServeQueries = true;
// Throttling for realtime consumption is disabled up to this point to
allow maximum consumption during startup time
- RealtimeConsumptionRateManager.getInstance().enableThrottling();
+ RealtimeConsumptionRateManager.getInstance().enablePartitionRateLimiter();
Review Comment:
This is actually the `PartitionRateLimiter`. I only made change to
`ServerRateLimiter`.
The reason is around that for our use-case we are more interested in
`serverRateLimiter` and I wanted to make less existing behaviour changes.
But I am also not against disabling throttling for `PartitionRateLimiter` as
well during startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
