somandal commented on code in PR #16341:
URL: https://github.com/apache/pinot/pull/16341#discussion_r2256973991


##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java:
##########
@@ -715,6 +715,13 @@ public RebalanceResult rebalance(
       @DefaultValue("false") @QueryParam("bootstrap") boolean bootstrap,
       @ApiParam(value = "Whether to allow downtime for the rebalance") 
@DefaultValue("false") @QueryParam("downtime")
       boolean downtime,
+      @ApiParam(value = "This flag only applies to peer-download enabled 
tables undergoing downtime=true or "
+          + "minAvailableReplicas=0 rebalance (both of which can result in 
possible data loss scenarios). If enabled, "
+          + "this flag will allow the rebalance to continue even in cases 
where data loss scenarios have been "
+          + "detected, otherwise the rebalance will be failed and user action 
will be required to rebalance again. "
+          + "This flag should be used with caution and only used in scenarios 
where data loss is acceptable")

Review Comment:
   I believe there is some manual steps to recover like deleting the segments 
and forcing re-consumption AFAIK. @noob-se7en can you also help here with 
recovery steps for such cases?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to