This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 7bad810374f Pauseless supports size based thresholds. Remove the todo
for the same (#16555)
7bad810374f is described below
commit 7bad810374f3ee3c372cf13e4b4d7036fa5804c4
Author: 9aman <[email protected]>
AuthorDate: Fri Aug 8 14:26:28 2025 +0530
Pauseless supports size based thresholds. Remove the todo for the same
(#16555)
---
.../helix/core/realtime/PinotLLCRealtimeSegmentManager.java | 4 ----
1 file changed, 4 deletions(-)
diff --git
a/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java
b/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java
index 099a49a1039..e0e5d291445 100644
---
a/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java
+++
b/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java
@@ -791,10 +791,6 @@ public class PinotLLCRealtimeSegmentManager {
long newSegmentCreationTimeMs = getCurrentTimeMs();
LLCSegmentName newLLCSegment = new LLCSegmentName(rawTableName,
committingSegmentPartitionGroupId,
committingLLCSegment.getSequenceNumber() + 1,
newSegmentCreationTimeMs);
- // TODO: This code does not support size-based segment thresholds for
tables with pauseless enabled. The
- // calculation of row thresholds based on segment size depends on the
size of the previously committed
- // segment. For tables with pauseless mode enabled, this size is
unavailable at this step because the
- // segment has not yet been built.
createNewSegmentZKMetadata(tableConfig, streamConfigs.get(0),
newLLCSegment, newSegmentCreationTimeMs,
committingSegmentDescriptor, committingSegmentZKMetadata,
instancePartitions, partitionIds.size(),
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
