xiangfu0 commented on code in PR #16553:
URL: https://github.com/apache/pinot/pull/16553#discussion_r2263877251
##########
pinot-plugins/pinot-file-system/pinot-s3/src/main/java/org/apache/pinot/plugin/filesystem/S3PinotFS.java:
##########
@@ -702,6 +740,28 @@ public void copyToLocalFile(URI srcUri, File dstFile)
_s3Client.getObject(getObjectRequest, ResponseTransformer.toFile(dstFile));
}
+ @Override
+ public void copyToLocalFile(URI srcUri, File dstFile)
+ throws Exception {
+ try {
+ LOGGER.info("Copy {} to local {}", srcUri, dstFile.getAbsolutePath());
+ copyToLocalFileInternal(srcUri, dstFile);
+ } catch (Exception e) {
+ LOGGER.warn("Caught exception during S3 copy, attempting to refresh
credentials and retry");
Review Comment:
I feel we also need to handle the refresh logic in other method? E.g. mkdir,
list files, delete file etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
