mqliang commented on PR #16665: URL: https://github.com/apache/pinot/pull/16665#issuecomment-3213269853
> There must be some Opentelemetry Collector processor which can help achieve the same thing we are achieving here? The major concern is: pinot metric name is NOT Opentelemetry friendly (or more specifically, not multi-dimension friendly), meaning: whenever pinot core call the metric SPI to emit metric, it has concatenated all attributes/dimensions into metric name. The concatenating happens at every caller place, not inside plugin implementation. So if using Opentelemetry Collector processor to collect the metric from JMX, it's still NOT multi-dimension metric. This make monitoring dashboard un-maintainable: we have to create a dashboard for each table, because table name has been concatenated into metric name. This PR emit multi-dimension metric, where table name is a dimension (or "attribute" in Opentelemetry's terminology). It will make dashboard more maintainable: you will be bale to create one dashboard, then on your metric platform UI, there will be a dropdown list to let you select the table. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
