sajjad-moradi commented on code in PR #16657:
URL: https://github.com/apache/pinot/pull/16657#discussion_r2301587377
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java:
##########
@@ -335,6 +335,18 @@ public void onConsumingToDropped(String segmentName) {
_ingestionDelayTracker.stopTrackingPartitionIngestionDelay(new
LLCSegmentName(segmentName).getPartitionGroupId());
}
+ /**
+ * Method to handle CONSUMING -> OFFLINE segment state transitions:
+ * We must stop tracking partitions for ingestion-delay if consuming segment
is marked as offline as there won't be
+ * any consumer present on the server for the partition segment is consuming
from.
+ *
+ * @param segmentName name of segment which is transitioning state.
+ */
+ @Override
+ public void onConsumingToOffline(String segmentName) {
+ _ingestionDelayTracker.stopTrackingPartitionIngestionDelay(new
LLCSegmentName(segmentName).getPartitionGroupId());
+ }
+
Review Comment:
When a consuming segment goes offline in IS, it never changes back to
consuming. RVM job creates a new consuming segment if all replicas of that
partition are offline in IS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
