yashmayya commented on PR #16455: URL: https://github.com/apache/pinot/pull/16455#issuecomment-3237033860
> One thing I'm concerning is the load of this periodic task. I added a rate limit set on each controller, for now only one tenant rebalance job allowed to retry at a time. For manual triggered tenant rebalance users are responsible to not schedule multiple tenant rebalances at the same time, but for this periodic task I think some protection is needed here to avoid unexpected huge load when multiple tenant rebalance jobs need retries. > > Wdyt? Also some loggers are added for observability. Logs are (almost) always good, thanks for adding them. Are you worried about the load on a particular controller or the load on the servers / cluster overall (due to rebalances)? I wouldn't overthink this part too much tbh, if there are multiple failed tenant rebalances being retried at the same time, it's likely that they were issued within the same time period by the user so it's okay for us to retry them together. Also, just to clarify, we shouldn't be retrying the same tenant rebalance job anyway right (across controllers as well as on the same controller)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
