somandal commented on code in PR #16722:
URL: https://github.com/apache/pinot/pull/16722#discussion_r2311213303
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/relocation/SegmentRelocator.java:
##########
@@ -182,34 +183,46 @@ BlockingQueue<String> getWaitingQueue() {
return _waitingQueue;
}
- private void rebalanceTable(String tableNameWithType) {
+ @VisibleForTesting
+ void rebalanceTable(String tableNameWithType) {
TableConfig tableConfig =
_pinotHelixResourceManager.getTableConfig(tableNameWithType);
Preconditions.checkState(tableConfig != null, "Failed to find table config
for table: %s", tableNameWithType);
+ RebalanceConfig rebalanceConfig = new RebalanceConfig();
+
boolean relocate = false;
- if (TierConfigUtils.shouldRelocateToTiers(tableConfig)) {
- relocate = true;
- LOGGER.info("Relocating segments to tiers for table: {}",
tableNameWithType);
- }
if (tableConfig.getTableType() == TableType.REALTIME
&&
InstanceAssignmentConfigUtils.shouldRelocateCompletedSegments(tableConfig)) {
relocate = true;
LOGGER.info("Relocating COMPLETED segments for table: {}",
tableNameWithType);
}
+ if (TierConfigUtils.shouldRelocateToTiers(tableConfig)) {
+ relocate = true;
+ rebalanceConfig.setUpdateTargetTier(true);
+ LOGGER.info("Relocating segments to tiers for table: {}",
tableNameWithType);
+ } else {
+ List<SegmentZKMetadata> segmentsZKMetadata =
_pinotHelixResourceManager.getSegmentsZKMetadata(tableNameWithType);
Review Comment:
sure fair point.
but what about my other question - does this support need to exist in
`SegmentRelocator`? isn't removing the config a 1 time activity?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
