xiaohui-sun commented on a change in pull request #4718: [TE] support row count
metric for Pinot
URL: https://github.com/apache/incubator-pinot/pull/4718#discussion_r336698265
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/auto/onboard/AutoOnboardPinotMetadataSource.java
##########
@@ -154,7 +158,7 @@ private boolean shouldRemoveDataset(DatasetConfigDTO
datasetConfigDTO, Set<Strin
List<MetricConfigDTO> metrics =
metricDAO.findByDataset(datasetConfigDTO.getDataset());
int metricCount = metrics.size();
for (MetricConfigDTO metric : metrics) {
- if (!metric.isDerived()) {
+ if (!metric.isDerived() && !metric.getName().equals(ROW_COUNT)) {
Review comment:
Are you planning to explicitly add a column called ROW_COUNT for all
datasets?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
