raghavyadav01 commented on code in PR #17396:
URL: https://github.com/apache/pinot/pull/17396#discussion_r2633163935
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/store/SingleFileIndexDirectory.java:
##########
@@ -449,7 +449,6 @@ public void removeIndex(String columnName, IndexType<?, ?,
?> indexType) {
// Text index is kept in its own files, thus can be removed directly.
if (indexType == StandardIndexes.text()) {
TextIndexUtils.cleanupTextIndex(_segmentDirectory, columnName);
- return;
Review Comment:
With storeInSegmentFile true TextIndex is present in pinot Segment and when
text Index is disabled we need to remove it from Segment. If we return early
the TextIndex from Segment is not removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
